Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add State status constants to spec-go #1046

Merged
merged 2 commits into from
Jul 10, 2020
Merged

Add State status constants to spec-go #1046

merged 2 commits into from
Jul 10, 2020

Conversation

RenaudWasTaken
Copy link
Contributor

@RenaudWasTaken RenaudWasTaken commented May 20, 2020 •
edited
Loading

Hello!

The State definition defines 4 constants for the status field that are not present in the specs-go

This PR adds them to the state.go file to make it available to runc.
/cc @cyphar @mrunalp @mikebrow

Signed-off-by: Renaud Gaubert [email protected]

tianon
tianon reviewed May 20, 2020
View reviewed changes
@RenaudWasTaken RenaudWasTaken force-pushed the state-const branch 2 times, most recently from 3dbe02e to 3e7de59 Compare May 20, 2020 22:35
mikebrow
mikebrow reviewed May 21, 2020
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

@mrunalp
Copy link
Contributor

mrunalp commented May 27, 2020 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@RenaudWasTaken RenaudWasTaken requested a review from tianon May 27, 2020 21:12
mikebrow
mikebrow reviewed May 27, 2020
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thaJeztah
thaJeztah reviewed Jul 1, 2020
View reviewed changes
@thaJeztah thaJeztah mentioned this pull request Jul 2, 2020
Closed
@thaJeztah
Copy link
Member

thaJeztah commented Jul 8, 2020 •
edited
Loading

ping @RenaudWasTaken could you have a look at #1046 (comment) ?

edit: argh wrong name

@RenaudWasTaken
Copy link
Contributor Author

Sorry looking at it now!

Renaud Gaubert and others added 2 commits July 8, 2020 20:31
Add State status constants to spec-go
89419f0 
Signed-off-by: Renaud Gaubert <[email protected]>
@thaJeztah
Use dedicated type for Container State
66ad83f 
Co-authored-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Renaud Gaubert <[email protected]>
@RenaudWasTaken
Copy link
Contributor Author

@thaJeztah applied!

thaJeztah
thaJeztah approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not a maintainer)

@thaJeztah
Copy link
Member

@mrunalp @tianon @cyphar PTAL

cyphar
cyphar approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

tianon
tianon approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianon tianon merged commit 3e4195d into opencontainers:master Jul 10, 2020
@RenaudWasTaken RenaudWasTaken mentioned this pull request Jul 21, 2020
Merged
@tianon tianon mentioned this pull request Aug 18, 2020
Closed
@AkihiroSuda AkihiroSuda mentioned this pull request Jan 24, 2023
Merged
@AkihiroSuda AkihiroSuda added this to the v1.1.0 milestone Feb 1, 2023
@AkihiroSuda AkihiroSuda mentioned this pull request Jun 26, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianon tianon tianon approved these changes

@cyphar cyphar cyphar approved these changes

@kolyshkin kolyshkin kolyshkin left review comments

@mikebrow mikebrow mikebrow left review comments

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
8 participants
@RenaudWasTaken @mrunalp @thaJeztah @tianon @cyphar @kolyshkin @mikebrow @AkihiroSuda